From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 19/24] rte_ether.h: stack vars declared at top of function Date: Sun, 13 May 2018 22:42:57 +0200 Message-ID: <2204550.NiTezdOFRo@xps> References: <152609021699.121661.5295227351721865436.stgit@localhost.localdomain> <152609041781.121661.10252991105854625648.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, stable@dpdk.org To: Andy Green Return-path: In-Reply-To: <152609041781.121661.10252991105854625648.stgit@localhost.localdomain> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/05/2018 04:00, Andy Green: > /projects/lagopus/src/dpdk/build/include/rte_ether.h: > In function 'rte_vlan_strip': > /projects/lagopus/src/dpdk/build/include/rte_ether.h:357:2: > warning: ISO C90 forbids mixed declarations and code > [-Wdeclaration-after-statement] > struct vlan_hdr *vh = (struct vlan_hdr *)(eh + 1); Fixes: c974021a5949 ("ether: add soft vlan encap/decap") Cc: stable@dpdk.org > Signed-off-by: Andy Green Applied, thanks