From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 02/24] lib/librte_ethdev: change eth-dev-ops API to return int Date: Mon, 14 May 2018 01:49:02 +0200 Message-ID: <2204566.stPqTexsKo@xps> References: <152609021699.121661.5295227351721865436.stgit@localhost.localdomain> <58706255.BWJRb5PVTu@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Stephen Hemminger To: Andy Green Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 90DF31BD89 for ; Mon, 14 May 2018 01:49:04 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/05/2018 01:10, Andy Green: > > On 05/13/2018 10:58 PM, Thomas Monjalon wrote: > > 12/05/2018 03:58, Andy Green: > >> Signed-off-by: Andy Green > > [...] > >> --- a/lib/librte_ethdev/rte_ethdev_core.h > >> +++ b/lib/librte_ethdev/rte_ethdev_core.h > >> -typedef uint32_t (*eth_rx_queue_count_t)(struct rte_eth_dev *dev, > >> - uint16_t rx_queue_id); > >> +typedef int (*eth_rx_queue_count_t)(struct rte_eth_dev *dev, > >> + uint16_t rx_queue_id); > >> /**< @internal Get number of used descriptors on a receive queue. */ > > > > What is the reason of this change? > > I thought I wasn't making enough patches, so I randomly started changing > stuff. > > Just kidding. Again, the original version of this patch just fixed the > compiler warning, but Stephen Hemminger > suggested going one level deeper and having this api return an int, so > it has a way to signal errors. It sounded reasonable to me so I did it. OK. You know it's difficult to read the history of this series because you don't use --in-reply-to to keep all revisions in the same thread. At least, please provide some explanations in the message area. Thanks