From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] eal: call plugin init before device parse
Date: Fri, 13 Oct 2017 15:40:02 +0200
Message-ID: <2207048.supWhzNK8P@xps>
References: <20171013115501.1345-1-santosh.shukla@caviumnetworks.com>
 <5bc3a00c-2027-7b83-db34-719bdae051be@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>,
 jerin.jacob@caviumnetworks.com
To: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 969B21B6D5
 for <dev@dpdk.org>; Fri, 13 Oct 2017 15:40:04 +0200 (CEST)
In-Reply-To: <5bc3a00c-2027-7b83-db34-719bdae051be@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

13/10/2017 14:35, Maxime Coquelin:
> 
> On 10/13/2017 01:55 PM, Santosh Shukla wrote:
> > Default eal_init code calls
> > 0. eal_plugins_init
> > 1. eal_option_device_parse
> > 2. rte_bus_scan
> > 
> > IOVA commit:cf408c224 missed on calling eal_plugins_init before
> > eal_option_device_parse, rte_bus_scan and that introduced below
> > regression for shared mode:
> > 
> > with CONFIG_RTE_BUILD_SHARED_LIB=y:
> > 
> > 'net_vhost0,iface=/tmp/vhost-user2' -d ./install/lib/librte_pmd_vhost.so
> > -- --portmask=1 --disable-hw-vlan -i --rxq=1 --txq=1 --nb-cores=1
> > --eth-peer=0,52:54:00:11:22:12
> > EAL: Detected 4 lcore(s)
> > ERROR: failed to parse device "net_vhost0"
> > EAL: Unable to parse device 'net_vhost0,iface=/tmp/vhost-user2'
> > PANIC in main():
> > Cannot init EAL
> > 
> > Fixes: cf408c224 ("eal: auto detect IOVA mode")
> > 
> > Reported-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> > Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> > ---
> >   lib/librte_eal/bsdapp/eal/eal.c   | 10 +++++++---
> >   lib/librte_eal/linuxapp/eal/eal.c | 10 +++++++---
> >   2 files changed, 14 insertions(+), 6 deletions(-)
> 
> Tested-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Applied, thanks