From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3 1/2] ethdev: add tunnel and port RSS
	offload types
Date: Tue, 21 Jun 2016 23:02:59 +0200
Message-ID: <2207246.eroZTxtGRd@xps13>
References: <1459250409-5123-2-git-send-email-jerin.jacob@caviumnetworks.com>
 <1459371063-7376-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1459371063-7376-2-git-send-email-jerin.jacob@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, bruce.richardson@intel.com, pablo.de.lara.guarch@intel.com,
 john.mcnamara@intel.com
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f49.google.com (mail-lf0-f49.google.com
 [209.85.215.49]) by dpdk.org (Postfix) with ESMTP id D79E8ADB2
 for <dev@dpdk.org>; Tue, 21 Jun 2016 23:03:01 +0200 (CEST)
Received: by mail-lf0-f49.google.com with SMTP id l188so42772738lfe.2
 for <dev@dpdk.org>; Tue, 21 Jun 2016 14:03:01 -0700 (PDT)
In-Reply-To: <1459371063-7376-2-git-send-email-jerin.jacob@caviumnetworks.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Jerin,

I wanted to push this patch which is now a dependency of ThunderX
but I do not fully understand it.

2016-03-31 02:21, Jerin Jacob:
> - added VXLAN, GENEVE and NVGRE tunnel flow types
> - added PORT flow type for accounting physical/virtual
> port or channel number in flow creation
[...]
> --- a/lib/librte_ether/rte_eth_ctrl.h
> +++ b/lib/librte_ether/rte_eth_ctrl.h
> @@ -74,7 +74,11 @@ extern "C" {
>  #define RTE_ETH_FLOW_IPV6_EX            15
>  #define RTE_ETH_FLOW_IPV6_TCP_EX        16
>  #define RTE_ETH_FLOW_IPV6_UDP_EX        17
> -#define RTE_ETH_FLOW_MAX                18
> +#define RTE_ETH_FLOW_PORT               18
> +#define RTE_ETH_FLOW_VXLAN              19
> +#define RTE_ETH_FLOW_GENEVE             20
> +#define RTE_ETH_FLOW_NVGRE              21
> +#define RTE_ETH_FLOW_MAX                22

Please could you explain more what is PORT flow?
Does it need a comment in the code?