From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 3/3] qat: fixes premature addition of
	AES_CMAC in session creation
Date: Fri, 11 Mar 2016 01:16:52 +0100
Message-ID: <2207806.zJzxy8f5VI@xps13>
References: <1457454137-22315-1-git-send-email-john.griffin@intel.com>
 <1457454137-22315-4-git-send-email-john.griffin@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: John Griffin <john.griffin@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id CDFD6376E
 for <dev@dpdk.org>; Fri, 11 Mar 2016 01:18:35 +0100 (CET)
Received: by mail-wm0-f49.google.com with SMTP id l68so8700159wml.0
 for <dev@dpdk.org>; Thu, 10 Mar 2016 16:18:35 -0800 (PST)
In-Reply-To: <1457454137-22315-4-git-send-email-john.griffin@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-08 16:22, John Griffin:
> Remove support for AES CMAC support for which was added to
> the code in error.  AES CMAC will be added in a subsequent release
> when testing completes.
[...]
>  	case RTE_CRYPTO_AUTH_AES_GCM:
> -	case RTE_CRYPTO_AUTH_AES_GMAC:

CMAC or GMAC?

>  		session->qat_hash_alg = ICP_QAT_HW_AUTH_ALGO_GALOIS_128;
>  		break;
>  	case RTE_CRYPTO_AUTH_SNOW3G_UIA2:
> @@ -312,6 +311,7 @@ qat_crypto_sym_configure_session_auth(struct rte_cryptodev *dev,
>  	case RTE_CRYPTO_AUTH_MD5:
>  	case RTE_CRYPTO_AUTH_MD5_HMAC:
>  	case RTE_CRYPTO_AUTH_AES_CCM:
> +	case RTE_CRYPTO_AUTH_AES_GMAC:

So it is added? What should we have later?