From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3] examples/skeleton-cat: PQoS CAT and CDP,
	example of libpqos usage
Date: Fri, 11 Mar 2016 14:50:18 +0100
Message-ID: <2207879.MgxKVmgPIQ@xps13>
References: <1456499233-66251-1-git-send-email-wojciechx.andralojc@intel.com>
 <1457369659-101377-1-git-send-email-wojciechx.andralojc@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Marcel D Cornu <marcel.d.cornu@intel.com>,
 Tomasz Kantecki <tomasz.kantecki@intel.com>
To: Wojciech Andralojc <wojciechx.andralojc@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50])
 by dpdk.org (Postfix) with ESMTP id B51152BF6
 for <dev@dpdk.org>; Fri, 11 Mar 2016 14:52:02 +0100 (CET)
Received: by mail-wm0-f50.google.com with SMTP id n186so19597140wmn.1
 for <dev@dpdk.org>; Fri, 11 Mar 2016 05:52:02 -0800 (PST)
In-Reply-To: <1457369659-101377-1-git-send-email-wojciechx.andralojc@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-07 16:54, Wojciech Andralojc:
> +M: Tomasz Kantecki <tomasz.kantecki@intel.com>
> +F: examples/skeleton-cat/
> +F: doc/guides/sample_app_ug/skeleton-cat.rst

Please keep the alphabetical order.

> +Basic Forwarding sample application is a simple *skeleton* example of
> +a forwarding application. It has been extended to make use of CAT via extended
> +command line options and linking against the libpqos library.

The skeleton aims to show a minimal piece of code (but bigger than hello world).
For any other usage, I think the "l2fwd" name is more appropriate.

> +DIRS-y += skeleton-cat

It cannot be enabled everytime, because of the dependency.
We already have this problem with examples/vm_power_manager
and libvirt dependency. It must be solved by improving the build system.

In this case, we can simply use the variable PQOS_LIBRARY_PATH to
enable the build.

[...]
> +# Default location of PQoS library and includes,
> +# can be overridden by command line or environment
> +PQOS_INSTALL_PATH ?= /usr/local/

This default value is useless because we should detect the dependency
before trying to compile.

[...]
> +LDLIBS += $(PQOS_LIBRARY_PATH) \

Why this backslash?