From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] i40e: fix the issue of port initialization failure Date: Thu, 04 Feb 2016 09:43:35 +0100 Message-ID: <2209475.O8bk1od0vQ@xps13> References: <1450848779-8183-1-git-send-email-helin.zhang@intel.com> <20160203163112.GA2528@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Zhang, Helin" Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 848D7F72 for ; Thu, 4 Feb 2016 09:44:49 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id r129so200584555wmr.0 for ; Thu, 04 Feb 2016 00:44:49 -0800 (PST) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-02-04 00:50, Zhang, Helin: > From: Richardson, Bruce > > can you please add an appropriately "fixes" line to the patch, since the subject > > explicitly calls it out as a bug-fix. Also, the words "the issue" in the subject can > > be removed as they don't add value. It would also be worthwhile referencing > > the adminq in the subject too, since that is the failure being reported. How > > about: > > > > "i40e: fix adminq failure on port init" > > Oh, sorry, I forgot this patch. > Firmware finally fixed it in FVL5, and we need to use new AQ commands for reading/writing some registers. > So I will drop this patch. Thanks! In such case, please mark it as "Rejected" in patchwork and self reply on the mailing list to advertise it is dropped. Thanks