From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] mk: link ring mempool by default for app build Date: Wed, 19 Apr 2017 14:26:47 +0200 Message-ID: <2210656.H7V8bvkmcr@xps> References: <1492074127-24339-1-git-send-email-shreyansh.jain@nxp.com> <20170418140408.69df3672@glumotte.dev.6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Olivier MATZ , "bruce.richardson@intel.com" , "john.miller@atomicrules.com" To: Shreyansh Jain Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 2251F559C for ; Wed, 19 Apr 2017 14:26:49 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/04/2017 14:25, Shreyansh Jain: > Hi Olivier, > From: Olivier MATZ [mailto:olivier.matz@6wind.com] > > On Thu, 13 Apr 2017 14:32:07 +0530, Shreyansh Jain > > wrote: > > > Signed-off-by: Shreyansh Jain > > > > Fixes: 9a8e9b57f544 ("mempool: move ring handler as a driver") > > > > Acked-by: Olivier Matz > > > > > --- > > > > > > Context: > > > From the discussion in [1], it was observed that application should > > > have a default pool already linked even in case of shared builds. > > > Ring is especially important because packet mbuf creation API refer to > > > ring_mp_mc as default handler. > > > > > > Documentation for this is pending. > > > > > > [1] http://dpdk.org/ml/archives/dev/2017-April/063819.html > > > > Maybe this comment could go in the patch. > > I can send another version of the patch with some part of the above > documentation within the patch commit. Moved the mempool ring line below the mempool line, Added the explanations, and Applied, thanks