From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] compressdev: implement API
Date: Sat, 24 Mar 2018 02:02:14 +0100
Message-ID: <2211509.83yEhUb72U@xps>
References: <1517595924-25963-1-git-send-email-fiona.trahe@intel.com>
 <1997769.o2qW9LT7Ur@xps>
 <348A99DA5F5B7549AA880327E580B43589360349@IRSMSX101.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "ahmed.mansour@nxp.com" <ahmed.mansour@nxp.com>,
 "Shally.Verma@cavium.com" <Shally.Verma@cavium.com>, "De Lara Guarch,
 Pablo" <pablo.de.lara.guarch@intel.com>,
 "fiona.trahe@gmail.com" <fiona.trahe@gmail.com>
To: "Trahe, Fiona" <fiona.trahe@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id A0EC84C8C
 for <dev@dpdk.org>; Sat, 24 Mar 2018 02:02:42 +0100 (CET)
In-Reply-To: <348A99DA5F5B7549AA880327E580B43589360349@IRSMSX101.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

23/03/2018 19:08, Trahe, Fiona:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 02/02/2018 19:25, Fiona Trahe:
> > >  lib/librte_compressdev/rte_comp.h                  | 503 ++++++++++++
> > 
> > Why rte_comp.h instead of the more consistent rte_compress.h?
> [Fiona]  I did originally... but ran into difficulty with horribly names like
> RTE_COMPRESS_COMPRESS
> RTE_COMPRESS_DECOMPRESS
> rte_compress_compress_xform
> rte_compress_decompress_xform
> So compress is both the module prefix and the name of one of the actions.
> I could have used compressdev - but names were very long.
> So decided to opt for using 
> _compressdev_ in names to do with the device and
> _comp_ in names to do with the compression service
> 
> Also I could have used compdev instead of compressdev, 
> but I felt compress should be in the lib name

I understand your concerns.
I don't like "comp" very much because it sounds like "comparison".
However, I don't have a better idea.
Sometimes naming is more difficult than coding :)