From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v4] eal: restrict cores auto detection Date: Wed, 21 Dec 2016 15:31:39 +0100 Message-ID: <22155206.MX3x2ThXoG@xps13> References: <1472693507-11369-1-git-send-email-jianfeng.tan@intel.com> <1697449.uzq8KWsvfF@xps13> <20161209151451.GB14536@bricha3-MOBL3.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Bruce Richardson , dev@dpdk.org, david.marchand@6wind.com, pmatilai@redhat.com To: Jianfeng Tan Return-path: Received: from mail-wj0-f174.google.com (mail-wj0-f174.google.com [209.85.210.174]) by dpdk.org (Postfix) with ESMTP id 042D8F968 for ; Wed, 21 Dec 2016 15:31:41 +0100 (CET) Received: by mail-wj0-f174.google.com with SMTP id xy5so203682483wjc.0 for ; Wed, 21 Dec 2016 06:31:41 -0800 (PST) In-Reply-To: <20161209151451.GB14536@bricha3-MOBL3.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-12-09 15:14, Bruce Richardson: > On Thu, Dec 08, 2016 at 07:19:41PM +0100, Thomas Monjalon wrote: > > 2016-12-02 17:48, Jianfeng Tan: > > > This patch uses pthread_getaffinity_np() to narrow down used > > > cores when none of below options is specified: > > > * coremask (-c) > > > * corelist (-l) > > > * and coremap (--lcores) > > > > > > The purpose of this patch is to leave out these core related options > > > when DPDK applications are deployed under container env, so that > > > users do not need decide the core related parameters when developing > > > applications. Instead, when applications are deployed in containers, > > > use cpu-set to constrain which cores can be used inside this container > > > instance. And DPDK application inside containers just rely on this > > > auto detect mechanism to start polling threads. > > > > > > Note: previously, some users are using isolated CPUs, which could > > > be excluded by default. Please add commands like taskset to use > > > those cores. > > > > > > Test example: > > > $ taskset 0xc0000 ./examples/helloworld/build/helloworld -m 1024 > > > > Bruce, what do you think of this version? > > It requires taskset only if -c, -l and --lcores are not used. > > > I'm fine with that since it maintains backward compatibilty for those > options. > > Acked-by: Bruce Richardson Applied with "s/specified/parsed/", thanks