From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2] e1000: mark rxq with RTE_SET_USED
Date: Wed, 28 Oct 2015 18:13:23 +0100
Message-ID: <2215673.djjjMEhqQv@xps13>
References: <1446048480-9139-1-git-send-email-harry.van.haaren@intel.com>
 <E115CCD9D858EF4F90C690B0DCB4D8973C83DE28@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com
 [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id 689BF8DA1
 for <dev@dpdk.org>; Wed, 28 Oct 2015 18:14:35 +0100 (CET)
Received: by wijp11 with SMTP id p11so263764318wij.0
 for <dev@dpdk.org>; Wed, 28 Oct 2015 10:14:35 -0700 (PDT)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8973C83DE28@IRSMSX108.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-10-28 16:18, De Lara Guarch, Pablo:
> > This patch marks rxq with RTE_SET_USED in
> > rx_desc_hlen_type_rss_to_pkt_flags(), when
> > ieee1588 is disabled. Previously a compilation
> > error occurred on unused-parameter.
> > 
> > Fixes: 1ce6591e238a ("igb: fix ieee1588 frame identification in i210")
> > 
> > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied, thanks

To avoid such break, we must check carefully the compilation with
different combinations of options.
Hope the automated tests will help us more in the near future.