From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [git pull] virtio changes for 17.11-rc1
Date: Sun, 08 Oct 2017 22:16:29 +0200
Message-ID: <2218306.fYRWOIo4Bx@xps>
References: <20171006064558.GE1545@yliu-home> <1963011.gX7c8kfyiN@xps>
 <20171008201006.7gqmyeofcw3m4ech@neon>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Olivier MATZ <olivier.matz@6wind.com>, maxime.coquelin@redhat.com,
 dev@dpdk.org
To: Yuanhan Liu <yliu@fridaylinux.org>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 7088B37A2
 for <dev@dpdk.org>; Sun,  8 Oct 2017 22:16:32 +0200 (CEST)
In-Reply-To: <20171008201006.7gqmyeofcw3m4ech@neon>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

08/10/2017 22:10, Olivier MATZ:
> Hi Thomas,
> 
> On Sat, Oct 07, 2017 at 04:37:53PM +0200, Thomas Monjalon wrote:
> > 06/10/2017 08:45, Yuanhan Liu:
> > > Hi Thomas,
> > > 
> > > Please consider pulling following virtio changes for 17.11-rc1 at
> > >     git://dpdk.org/next/dpdk-next-virtio    master
> > 
> > There is a compilation error on ARM with
> > "net/virtio: rationalize setting of Rx/Tx handlers"
> > An include of rte_cpuflags.h is missing.
> 
> I confirm that this include is missing in virtio_ethdev.c, breaking
> compilation on arm (thanks for spotting it):
> 
>  virtio_ethdev.c: In function 'virtio_dev_configure':
>  virtio_ethdev.c:1748:7: error: implicit declaration of function
>         'rte_cpu_get_flag_enabled' [-Werror=implicit-function-declaration]
>    if (!rte_cpu_get_flag_enabled(RTE_CPUFLAG_NEON)) {
>         ^
> 
> Thomas, about this issue, what do you expect? I can send another patch
> if required.

It can be fixed by Yuanhan in next-virtio tree.