From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] mk: disable ICC warning 188
Date: Wed, 04 Jan 2017 20:57:04 +0100
Message-ID: <2218904.6u9s4lZvRY@xps13>
References: <20170103161542.27303-1-ferruh.yigit@intel.com>
 <20170103171907.GD12822@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>, dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wj0-f172.google.com (mail-wj0-f172.google.com
 [209.85.210.172]) by dpdk.org (Postfix) with ESMTP id 9B7842B9C
 for <dev@dpdk.org>; Wed,  4 Jan 2017 20:57:06 +0100 (CET)
Received: by mail-wj0-f172.google.com with SMTP id tq7so240633342wjb.0
 for <dev@dpdk.org>; Wed, 04 Jan 2017 11:57:06 -0800 (PST)
In-Reply-To: <20170103171907.GD12822@6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-01-03 18:19, Adrien Mazarguil:
> On Tue, Jan 03, 2017 at 04:15:42PM +0000, Ferruh Yigit wrote:
> > error #188: enumerated type mixed with another type
> > 
> > This is get when an integer assigned to an enum variable.
> > 
> > Since this usage is common and causing many ICC compilation errors, and
> > other compilers accept this usage. Disabling the warning.
> > 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> I also think this warning may be useful but is not worth the trouble in many
> cases, thus:
> 
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Applied, thanks

I think we should mark ICC support as best effort to make clear
that no ICC check is required from contributors.