From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [dpdk-stable] [PATCH v5 10/10] mk: remove unnecessary make rules of test Date: Fri, 27 Jul 2018 10:45:36 +0200 Message-ID: <2222106.qzOVikEJ9E@xps> References: <1531843225-14638-1-git-send-email-reshma.pattan@intel.com> <1541166.PTxugTrkH4@xps> <3AEA2BF9852C6F48A459DA490692831F2A376E12@IRSMSX109.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: "stable@dpdk.org" , "dev@dpdk.org" , "Burakov, Anatoly" , "Parthasarathy, JananeeX M" , "Yigit, Ferruh" To: "Pattan, Reshma" Return-path: In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A376E12@IRSMSX109.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/07/2018 10:22, Pattan, Reshma: > Hi, > > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Thursday, July 26, 2018 9:08 PM > > To: Pattan, Reshma > > Cc: stable@dpdk.org; dev@dpdk.org; Burakov, Anatoly > > ; Parthasarathy, JananeeX M > > ; Yigit, Ferruh > > > > Subject: Re: [dpdk-stable] [PATCH v5 10/10] mk: remove unnecessary make > > rules of test > > > > 17/07/2018 18:00, Reshma Pattan: > > > make rule test-basic is duplicate of test rule. > > > removed unused test-mempool and test-ring make rules. > > > > > > Fixes: a3df7f8d9c ("mk: rename test related rules") > > > Fixes: a3df7f8d9c ("mk: rename test related rules") > > > CC: stable@dpdk.org > > > CC: ferruh.yigit@intel.com > > > > > > Signed-off-by: Reshma Pattan > > > --- > > > -.PHONY: test test-basic test-fast test-ring test-mempool test-perf > > > coverage test-drivers test-dump -test test-basic test-fast test-ring test- > > mempool test-perf coverage test-drivers test-dump: > > > +.PHONY: test test-fast test-perf coverage test-drivers test-dump test > > > +test-fast test-perf coverage test-drivers test-dump: > > > > Why keeping test-ring test-mempool ? > > > > Test-ring and test-mempool are removed now. As they were unused from the past. Reading again, yes, this commit is about removing them. Sorry, my question is a non-sense :)