From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] lib/ether: prevent duplicate callback on list Date: Tue, 25 Oct 2016 23:35:02 +0200 Message-ID: <2223568.QpbvufUhIb@xps13> References: <1476970481-21034-1-git-send-email-daniels@research.att.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "E. Scott Daniels" Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id C5D696CBD for ; Tue, 25 Oct 2016 23:35:04 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id d128so51392714wmf.1 for ; Tue, 25 Oct 2016 14:35:04 -0700 (PDT) In-Reply-To: <1476970481-21034-1-git-send-email-daniels@research.att.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-10-20 09:34, E. Scott Daniels: > This change prevents the attempt to add a structure which is > already on the callback list. If a struct with matching > parameters is found on the list, then no action is taken. If > a struct with matching parameters is found on the list, then > no action is taken. Callback is not duplicate anymore but the last sentence is duplicate :) > Fixes: ac2f69c ("ethdev: fix crash if malloc of user callback fails") > > Signed-off-by: E. Scott Daniels > --- > > V2: > * Correct the component name; changed from net/ixgbe. > * Add Fixes tag. > * Acked-by: Wenzhuo Lu The Acked-by tag must be added below your Signed-off-by. Applied with above nits fixed, thanks