From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] scripts: check commits with checkpatch
Date: Tue, 07 Jun 2016 09:43:58 +0200
Message-ID: <2224175.I7JDXGyCVZ@xps13>
References: <1464858795-3152-1-git-send-email-thomas.monjalon@6wind.com>
 <20160602123337.GA14836@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id B36918E5D
 for <dev@dpdk.org>; Tue,  7 Jun 2016 09:43:59 +0200 (CEST)
Received: by mail-wm0-f46.google.com with SMTP id r5so7116136wmr.0
 for <dev@dpdk.org>; Tue, 07 Jun 2016 00:43:59 -0700 (PDT)
In-Reply-To: <20160602123337.GA14836@bricha3-MOBL3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-06-02 13:33, Bruce Richardson:
> On Thu, Jun 02, 2016 at 11:13:15AM +0200, Thomas Monjalon wrote:
> > The new option -n allows to give a number of commits to check
> > from the git HEAD.
> > If neither -n nor patch files are given, the commits after
> > origin/master are checked.
> > 
> 
> Yep, I love it, exactly what I wanted to replace my own checkpatch script wrapper!
> 
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
> Testing this out here, I find that git format-patch includes the diff stats
> in the output, which then can trigger long-line warnings for the commit message.
> 
> 	WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
> 	#8:
> 	 examples/my-new-test-app/basicfwd.c | 342 +++++++++++++++++++++++++++++++++++++
> 
> To fix this, I suggest replacing "format-patch --stdout" with "show --format=email"
> since that should give the same output just without the change stats.
> 
> With this one adjustment:
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied with --no-stat adjustment.