From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v8 2/2] config: enable vhost numa awareness
	by default
Date: Tue, 27 Jun 2017 11:21:50 +0200
Message-ID: <2224754.8CF9r2HNLB@xps>
References: <1498039711-26570-1-git-send-email-i.maximets@samsung.com>
 <1498553186-24541-3-git-send-email-i.maximets@samsung.com>
 <4898a4e7-491a-783e-46e0-ba991099476a@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Ilya Maximets <i.maximets@samsung.com>, dev@dpdk.org,
 David Marchand <david.marchand@6wind.com>,
 Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>,
 Heetae Ahn <heetae82.ahn@samsung.com>, Yuanhan Liu <yliu@fridaylinux.org>,
 Jianfeng Tan <jianfeng.tan@intel.com>, Neil Horman <nhorman@tuxdriver.com>,
 Yulong Pei <yulong.pei@intel.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id EBDE8235
 for <dev@dpdk.org>; Tue, 27 Jun 2017 11:21:51 +0200 (CEST)
In-Reply-To: <4898a4e7-491a-783e-46e0-ba991099476a@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

27/06/2017 11:18, Hemant Agrawal:
> On 6/27/2017 2:16 PM, Ilya Maximets wrote:
> > It is safe to enable LIBRTE_VHOST_NUMA by default for all
> > configurations where libnuma is already a default dependency.
> >
> > Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
> > ---
> >  config/common_linuxapp                    | 1 +
> >  config/defconfig_arm-armv7a-linuxapp-gcc  | 1 +
> >  config/defconfig_arm64-dpaa2-linuxapp-gcc | 1 +
> >  3 files changed, 3 insertions(+)
[...]
> > --- a/config/defconfig_arm64-dpaa2-linuxapp-gcc
> > +++ b/config/defconfig_arm64-dpaa2-linuxapp-gcc
> > @@ -47,6 +47,7 @@ CONFIG_RTE_PKTMBUF_HEADROOM=256
> >
> >  # Doesn't support NUMA
> >  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
> > +CONFIG_RTE_LIBRTE_VHOST_NUMA=n
> >
> >  #
> >  # Compile Support Libraries for DPAA2
> >
> 
> -1
> It should also be disabled for generic ARM64. This patch is breaking 
> generic arm64 config tests on our platforms and creating a unnecessary 
> dependency.

What do you mean? Which ARM64 platform is it breaking?
We can specifically disable it on more platforms.