From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] test/memory: fixing line parsing in memory autotest Date: Sun, 12 Nov 2017 03:48:41 +0100 Message-ID: <2225299.YYgmiRYW01@xps> References: <1510251272-32549-1-git-send-email-radoslaw.biernacki@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, sergio.gonzalez.monroy@intel.com, santosh.shukla@caviumnetworks.com, anatoly.burakov@intel.com To: Radoslaw Biernacki Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 1783E1B217 for ; Sun, 12 Nov 2017 03:48:43 +0100 (CET) In-Reply-To: <1510251272-32549-1-git-send-email-radoslaw.biernacki@linaro.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/11/2017 19:14, Radoslaw Biernacki: > This patch fixes three problems in memory autotest: > - the regex for IOVA > - missing validation of second and following output lines > - propagation of error to consecutive tests > - conversion base for mem size (hex indtead of dec) > First fix is for changes introduced with IOVA, the regex was not > updated which lead to unit test failure. Patch now also uses loop for > line outputs processing to verify more than just one line. By this we > also satisfy the pexpect() and scan the "Test OK"/"Test Failed" so in > case of error all output lines are consumed and does not break the > consecutive test (error does not propagate). > > Fixes: 7ba49d39f14c ("mem: rename segment address from physical to IOVA") > Fixes: b4ce15aa2bc7 ("app/test: fix memory autotest") > > Signed-off-by: Radoslaw Biernacki Applied, thanks