From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v9 01/12] eal: Fix coding style of eal_pci.c and eal_pci_uio.c Date: Wed, 08 Jul 2015 22:30:51 +0200 Message-ID: <2227940.VzWfs9Otk4@xps13> References: <1435652668-3380-12-git-send-email-mukawa@igel.co.jp> <1436351693-2349-2-git-send-email-mukawa@igel.co.jp> <20150708090958.70c1dbcf@urahara> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Stephen Hemminger , Tetsuya Mukawa Return-path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id 174975A52 for ; Wed, 8 Jul 2015 22:31:58 +0200 (CEST) Received: by wiga1 with SMTP id a1so295320698wig.0 for ; Wed, 08 Jul 2015 13:31:57 -0700 (PDT) In-Reply-To: <20150708090958.70c1dbcf@urahara> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-07-08 09:09, Stephen Hemminger: > On Wed, 8 Jul 2015 19:34:42 +0900 > Tetsuya Mukawa wrote: > > > diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal/bsdapp/eal/eal_pci.c > > index 2df5c1c..a63d450 100644 > > --- a/lib/librte_eal/bsdapp/eal/eal_pci.c > > +++ b/lib/librte_eal/bsdapp/eal/eal_pci.c > > @@ -2,6 +2,7 @@ > > * BSD LICENSE > > * > > * Copyright(c) 2010-2014 Intel Corporation. All rights reserved. > > + * Copyright(c) 2015 IGEL Co., Ltd. > > I think copyright in file should stay with original author, otherwise > the Copyright will keep growing with all patches. Yes you're right. There is no strict rule, but Copyright should be added only in new files or with a really significant change. Tetsuya, you have copyright on PMD null and hotplug framework in doc. Hope you'll agree to not add new ones while doing some EAL cleanup.