From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] lib/librte_mbuf: remove void * pointer cast
Date: Fri, 19 Jan 2018 10:37:57 +0100
Message-ID: <22300087.hk3FSSTWuc@xps>
References: <20180119091240.25085-1-zhiyong.yang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, ferruh.yigit@intel.com, olivier.matz@6wind.com
To: Zhiyong Yang <zhiyong.yang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id D6C111B040
 for <dev@dpdk.org>; Fri, 19 Jan 2018 10:38:34 +0100 (CET)
In-Reply-To: <20180119091240.25085-1-zhiyong.yang@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Zhiyong,

3 comments about patch formatting:

1/ the title must follow the convention seen in the git history.
If you use git log --oneline lib/librte_mbuf
you will see that it must start with "mbuf:"

2/ The * character does not play well when patch saved in a file,
and it is useless: "void pointer" is correct for understanding.

3/ You must Cc the maintainer as described in MAINTAINERS.
You can use devtools/get-maintainer.sh.
Here, I Cc Olivier.

Thanks


19/01/2018 10:12, Zhiyong Yang:
> It is unnecessary to cast from void * to struct rte_mbuf *,
> the change can make code more simple.
> 
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>