From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] build: set CFLAGS for ppc64el build
Date: Fri, 12 Feb 2016 18:37:01 +0100
Message-ID: <2231851.1TVA0CgCFh@xps13>
References: <1455296713-7417-1-git-send-email-ferseiti@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Fernando Seiti Furusato <ferseiti@linux.vnet.ibm.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id 22CE995D4
 for <dev@dpdk.org>; Fri, 12 Feb 2016 18:38:32 +0100 (CET)
Received: by mail-wm0-f44.google.com with SMTP id c200so31037870wme.0
 for <dev@dpdk.org>; Fri, 12 Feb 2016 09:38:32 -0800 (PST)
In-Reply-To: <1455296713-7417-1-git-send-email-ferseiti@linux.vnet.ibm.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-02-12 12:05, Fernando Seiti Furusato:
> Add a proper ifeq statement to set the mcpu as needed for ppc64el, as
> the only one originally set is not valid for ppc architectures.

What is the benefit of using the default machine config, compared to
the power8 one?

Don't you think the default machine should be renamed core2?

[...]
> +ifeq (ppc64le,$(shell uname -m))
> +        MACHINE_CFLAGS += -mcpu=power8

Why this flag is not set in mk/machine/power8/rte.vars.mk ?