From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v4 0/4] app/test: rework crypto AES unit test
Date: Mon, 13 Jun 2016 22:26:26 +0200
Message-ID: <2237985.4XU0RlZNqR@xps13>
References: <1465822420-8287-1-git-send-email-roy.fan.zhang@intel.com>
 <1465826893-20392-1-git-send-email-roy.fan.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, declan.doherty@intel.com,
 Pablo de Lara <pablo.de.lara.guarch@intel.com>
To: Fan Zhang <roy.fan.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id EA2662C09
 for <dev@dpdk.org>; Mon, 13 Jun 2016 22:26:28 +0200 (CEST)
Received: by mail-wm0-f54.google.com with SMTP id v199so93637583wmv.0
 for <dev@dpdk.org>; Mon, 13 Jun 2016 13:26:28 -0700 (PDT)
In-Reply-To: <1465826893-20392-1-git-send-email-roy.fan.zhang@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> Fan Zhang (4):
>   app/test: categorize crypto AES test vectors into new file
>   app/test: add unified crypto aes test
>   app/test: utilize new unified crypto AES test function
>   app/test: add crypto AES-CBC-128 HMAC-SHA224 and HMAC-SHA384 unit
>     tests

My first comment on v1 was:
"
The first three patches have no real meaning separately.
As they move and rework some code, it is better to not split
with some patches which add code from nowhere and others which
remove old code.
Please squash.
"

Do you agree I squash the first 3 patches?

Any other reviewer for this big patchset?