From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 0/4] ethdev: add per-PMD tuning of RxTx parmeters Date: Sat, 31 Mar 2018 02:05:22 +0200 Message-ID: <2244353.QZW83d2S2R@xps> References: <20180321142749.27520-1-remy.horton@intel.com> <8f7021b0-ea88-d2a9-c2df-080a6aabc78e@intel.com> <44b33e0e-9a1b-86ce-24ab-d123b9a1068e@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, John McNamara , Wenzhuo Lu , Jingjing Wu , Qi Zhang , Beilei Xing , Shreyansh Jain To: Ferruh Yigit , Remy Horton Return-path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id B28F05F1C for ; Sat, 31 Mar 2018 02:05:39 +0200 (CEST) In-Reply-To: <44b33e0e-9a1b-86ce-24ab-d123b9a1068e@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 30/03/2018 12:34, Ferruh Yigit: > On 3/27/2018 7:43 PM, Ferruh Yigit wrote: > > On 3/21/2018 2:27 PM, Remy Horton wrote: > >> The optimal values of several transmission & reception related parameters, > >> such as burst sizes, descriptor ring sizes, and number of queues, varies > >> between different network interface devices. This patchset allows individual > >> PMDs to specify their preferred parameter values, and if so indicated by an > >> application, for them to be used automatically by the ethdev layer. > >> > >> rte_eth_dev_configure() has been changed so that specifying zero for both > >> nb_rx_q AND nb_tx_q causes it to use driver preferred values, and if these > >> are not available, falls back to EAL defaults. Setting one (but not both) > >> to zero does not cause the use of defaults, as having one of them zeroed is > >> a valid setup. > >> > >> This RFC/V1 includes per-PMD values for e1000 and i40e but it is expected > >> that subsequent patchsets will cover other PMDs. A deprecation notice > >> covering the API/ABI change is in place. > >> > >> > >> Changes in v2: > >> * Rebased to > >> * Removed fallback values from rte_eth_dev_info_get() > >> * Added fallback values to rte_rte_[rt]x_queue_setup() > >> * Added fallback values to rte_eth_dev_configure() > >> * Corrected comment > >> * Removed deprecation notice > >> * Split RX and Tx into seperate structures > >> * Changed parameter names > >> > >> > >> Remy Horton (4): > >> ethdev: add support for PMD-tuned Tx/Rx parameters > >> net/e1000: add TxRx tuning parameters > >> net/i40e: add TxRx tuning parameters > >> testpmd: make use of per-PMD TxRx parameters > > > > Reviewed-by: Ferruh Yigit > > Series applied to dpdk-next-net/master, thanks. I prefer not pulling this series in master and give a chance to have a more complete v3 for testpmd and examples.