From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v1 0/2] ring C11 library fix and optimization Date: Tue, 13 Nov 2018 16:57:49 +0100 Message-ID: <2246047.F6nQ2GSFza@xps> References: <1541763767-7399-1-git-send-email-gavin.hu@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, stephen@networkplumber.org, olivier.matz@6wind.com, chaozhu@linux.vnet.ibm.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, jerin.jacob@caviumnetworks.com, Honnappa.Nagarahalli@arm.com To: Gavin Hu Return-path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id B7F6034F3 for ; Tue, 13 Nov 2018 16:57:54 +0100 (CET) In-Reply-To: <1541763767-7399-1-git-send-email-gavin.hu@arm.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/11/2018 12:42, Gavin Hu: > V1: > Update the ring C11 library including the following changes: > 1) On relaxed ordering platforms(like Arm64,PPPC), in ring C11 implementation, > loading head and tail might be reodered, this makes CAS(compare and retry > the flow if the head is outdated) not working as expected, the fix is to > ensure the head is read before the tail, leaving no chances of the combination > of outdated head and new tail. > 2) With the above memory fence introduced, some loading can be relaxed. > > Gavin Hu (2): > ring: keep the deterministic order allowing retry to work > ring: relaxed ordering for load and store the head No comment, so I guess it can enter in 18.11-rc3. Applied, thanks