From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v4 0/5] lib/librte_vhost: user space vhost cuse driver library Date: Wed, 24 Sep 2014 18:21:58 +0200 Message-ID: <2248333.HL0PhLEb6K@xps13> References: <1410519304-14521-1-git-send-email-huawei.xie@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Xie, Huawei" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi, 2014-09-24 14:32, Ouyang, Changchun: > This v4 patch remove the jumbo frame related codes > and Huawei will add it back in a separate patch, I'd prefer a v5 which includes these changes. I know this patchset is pending and reworked many times, so I'll try to integrate v5 with top priority. Other comments: - examples/vhost/Makefile should not be copied (and removed just after) - coding style fixes are aligning things but antislashes are not well aligned - fuse-devel and kernel-modules-extra packages are not available in this form in all distributions, it's better to describe what is behind these package names (especially for kernel-modules-extra) I won't have time to properly review the big refactoring. But I'm sure we'll better check it when using it once integrated. The essential is to be able to view the changes in the git history. Thanks for this effort. -- Thomas