From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] app/testpmd: support bitmask for RSS and FDIR
Date: Mon, 06 Aug 2018 11:30:34 +0200
Message-ID: <2252677.DSoj0ZM9iK@xps>
References: <1533534335-119817-1-git-send-email-beilei.xing@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, wenzhuo.lu@intel.com, jingjing.wu@intel.com
To: Beilei Xing <beilei.xing@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id D39181B46E
 for <dev@dpdk.org>; Mon,  6 Aug 2018 11:30:38 +0200 (CEST)
In-Reply-To: <1533534335-119817-1-git-send-email-beilei.xing@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

06/08/2018 07:45, Beilei Xing:
> This patch adds bitmask support for RSS, FDIR
> and FDIR flexible payload.
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>

Flow director API is deprecated for almost 2 years:
	http://git.dpdk.org/dpdk/commit/?id=7fdcde6
We asked several times to stop using it in i40e.
It has not been listened.
We have even accepted a workaround in flow_filtering example for i40e: 
	http://git.dpdk.org/dpdk/commit/?id=9a93446
We need to stop and move all to a common rte_flow API.

As a consequence, I will be against this patch.