From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] bus/vdev: replace device list lock by a recursive one Date: Tue, 22 May 2018 16:38:06 +0200 Message-ID: <2257563.PQC7AstAyf@xps> References: <2833093.uzJjkH71XI@xps> <20180522113727.3116-1-thomas@monjalon.net> <8ac95032-f1e3-d762-2cf5-803ad78bb2bb@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: "Burakov, Anatoly" , matan@mellanox.com, ferruh.yigit@intel.com, gaetan.rivet@6wind.com To: dev@dpdk.org Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id D8C57493D for ; Tue, 22 May 2018 16:38:08 +0200 (CEST) In-Reply-To: <8ac95032-f1e3-d762-2cf5-803ad78bb2bb@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/05/2018 15:34, Burakov, Anatoly: > On 22-May-18 12:37 PM, Thomas Monjalon wrote: > > A device like failsafe can manage sub-devices. > > When removing such device, it removes its sub-devices > > and try to take the same vdev_device_list_lock. > > It was causing a deadlock because the lock was not recursive. > > > > Fixes: 35f462839b69 ("bus/vdev: add lock on device list") > > > > Suggested-by: Anatoly Burakov > > Signed-off-by: Thomas Monjalon > > --- > > v3: try recursive lock > > WARNING: not yet tested! > > --- > > LGTM > > Acked-by: Anatoly Burakov Tested-by: Matan Azrad Applied