From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 1/4] acl: Add ACL library (librte_acl) into DPDK. Date: Wed, 28 May 2014 00:21:33 +0200 Message-ID: <2262681.BL9UtmWIVt@xps13> References: <1400791734-24479-1-git-send-email-konstantin.ananyev@intel.com> <1400791734-24479-2-git-send-email-konstantin.ananyev@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Konstantin Ananyev Return-path: In-Reply-To: <1400791734-24479-2-git-send-email-konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Konstantin, Glad to see this new library coming in. 2014-05-22 21:48, Konstantin Ananyev: > The ACL library is used to perform an N-tuple search over a set of rules > with multiple categories and find the best match for each category. > > Signed-off-by: Konstantin Ananyev > --- > config/common_linuxapp | 6 + > lib/librte_acl/Makefile | 60 + > lib/librte_acl/acl.h | 182 +++ > lib/librte_acl/acl_bld.c | 2002 ++++++++++++++++++++++++++++++++++ > lib/librte_acl/acl_gen.c | 473 ++++++++ > lib/librte_acl/acl_run.c | 927 ++++++++++++++++ > lib/librte_acl/acl_vect.h | 129 +++ > lib/librte_acl/rte_acl.c | 413 +++++++ > lib/librte_acl/rte_acl.h | 453 ++++++++ > lib/librte_acl/rte_acl_osdep.h | 92 ++ > lib/librte_acl/rte_acl_osdep_alone.h | 277 +++++ > lib/librte_acl/tb_mem.c | 102 ++ > lib/librte_acl/tb_mem.h | 73 ++ > 13 files changed, 5189 insertions(+), 0 deletions(-) As you are introducing a new library, you need to update doxygen configuration and start page: doc/doxy-api.conf doc/doxy-api-index.md I've run checkpatch.pl from kernel.org on these ACL patches and it reports a lot of code style issues. Could you have a look at it please? Thanks -- Thomas