From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3 1/5] ethdev: remove useless parameter in
	callback process
Date: Wed, 03 Jan 2018 09:17:01 +0100
Message-ID: <2264748.ymP9TsbnYi@xps>
References: <20171128221302.15400-1-thomas@monjalon.net>
 <8CEF83825BEC744B83065625E567D7C24E06EEA4@IRSMSX108.ger.corp.intel.com>
 <20180102122138.GA8096@hmswarspite.think-freely.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Yigit, Ferruh" <ferruh.yigit@intel.com>
To: Neil Horman <nhorman@tuxdriver.com>, "Iremonger,
 Bernard" <bernard.iremonger@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 3D6411B168
 for <dev@dpdk.org>; Wed,  3 Jan 2018 09:17:19 +0100 (CET)
In-Reply-To: <20180102122138.GA8096@hmswarspite.think-freely.org>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

02/01/2018 13:21, Neil Horman:
> On Tue, Jan 02, 2018 at 11:35:02AM +0000, Iremonger, Bernard wrote:
> > >  int _rte_eth_dev_callback_process(struct rte_eth_dev *dev,
> > > -		enum rte_eth_event_type event, void *cb_arg, void *ret_param);
> > > +		enum rte_eth_event_type event, void *ret_param);
> > 
> > As this is a change to the public API of librte_ether is a deprecation notice needed ?
> > This API is currently used by the test/test/virtual_pmd.c APP and may be used by other APP's in the field. 
> >  
> Agreed, it definately should go through the deprecation process

This function is used by drivers only, that's why there is an underscore
at the beginning of its name.
So it is not part of the regular ABI and does not need any deprecation
notice, in my opinion.