From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F56EC43331 for ; Thu, 2 Apr 2020 11:20:27 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id F346B20675 for ; Thu, 2 Apr 2020 11:20:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="s6p9SqVr"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="oFC5K/N7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F346B20675 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 47DE32C15; Thu, 2 Apr 2020 13:20:26 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id E3B82FFA for ; Thu, 2 Apr 2020 13:20:24 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 7F6495C02A3; Thu, 2 Apr 2020 07:20:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 02 Apr 2020 07:20:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=TR3trd67bh1ZPojm6QTHJZK77tWzPf0VrrAbaH/tOwU=; b=s6p9SqVrvu2D QJIUfz+XEaleVIwthIAHkf8wOqizab7wfaohOyNEBnPagMpnBSc5IWo2/QtUv20k +Ewtbq8zVC6X54YJdfiaUvjkTOQerBPH7iBfI2uSNEYYWwqo1VJ8xIfN05r1pwLW QXc7NRcoMkhzgu7BCiWezP5plPgolMk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=TR3trd67bh1ZPojm6QTHJZK77tWzPf0VrrAbaH/tO wU=; b=oFC5K/N76FRdAbxv8zwtXj9shSMRFiReXtCntii5X4SeR1g3sbcdJBHLd uMYD+gfflbQS4arc+rOo4Yc8/rXmcAxwRqgDmAcASG4wO9/4wI/998Ks4G5+QcMX fytz7l6k1fbbxIryU7GoyBHxZ/4Khi+FXhaM9mvGaiAFfKz8z+njDqiU1PxPIWQr xo+G0bvNSH10/CBNerb9satFug+wwVAEEk92fzjaRYa+c+X33Xku55PYyHhv63eP UC71l/FpEMzfu0xnOSx0KtnnrC7JsN78R6KFrNRbeGcgtViObp2IBW7SP8K5pSEK nE6pfAe92iH7miu6u2VMc98kkuvYw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrtdeggdeffecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 98519328005A; Thu, 2 Apr 2020 07:20:22 -0400 (EDT) From: Thomas Monjalon To: Viacheslav Ovsiienko Cc: dev@dpdk.org, ferruh.yigit@intel.com, bernard.iremonger@intel.com Date: Thu, 02 Apr 2020 13:20:21 +0200 Message-ID: <2267488.53lzm7zTb9@xps> In-Reply-To: <1584625851-10291-3-git-send-email-viacheslavo@mellanox.com> References: <1561553317-16777-1-git-send-email-viacheslavo@mellanox.com> <1584625851-10291-1-git-send-email-viacheslavo@mellanox.com> <1584625851-10291-3-git-send-email-viacheslavo@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: gather Rx and Tx routines profiling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/03/2020 14:50, Viacheslav Ovsiienko: > + if (fwdprof_flags & RECORD_CORE_CYCLES_RX && total_recv > 0) > + printf("\n rx CPU cycles/packet=%u (total cycles=" > + "%"PRIu64" / total RX packets=%"PRIu64")\n", > + (unsigned int)(rx_cycles / total_recv), > + rx_cycles, total_recv); > + if (fwdprof_flags & RECORD_CORE_CYCLES_TX && total_xmit > 0) > + printf("\n tx CPU cycles/packet=%u (total cycles=" > + "%"PRIu64" / total TX packets=%"PRIu64")\n", > + (unsigned int)(tx_cycles / total_xmit), > + tx_cycles, total_xmit); This is the "UI", so I think it deserves a cautious review. Instead of "=" without space, I think ": " is easier to read. Please use "Rx" and "Tx" instead of lowercase ones. "CPU cycles/packet" is hard to read. I would prefer either "cycles/packet" without CPU or "cycles per packet" I will continue some UI comments in next patch.