From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v11 07/13] pci: split match and probe
Date: Wed, 15 Feb 2017 12:22:57 +0100
Message-ID: <2268750.t8Q9V8CvVb@xps13>
References: <1484748329-5418-1-git-send-email-shreyansh.jain@nxp.com>
 <1484801117-779-8-git-send-email-thomas.monjalon@6wind.com>
 <CALe+Z03-V+NWPYkHzUU7KbfTrEuLM4+7E4SU_sFrsTXaWo9VTQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Jan Blunck <jblunck@infradead.org>, Shreyansh Jain <shreyansh.jain@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53])
 by dpdk.org (Postfix) with ESMTP id 48FC59E7
 for <dev@dpdk.org>; Wed, 15 Feb 2017 12:22:59 +0100 (CET)
Received: by mail-wm0-f53.google.com with SMTP id r141so38086751wmg.1
 for <dev@dpdk.org>; Wed, 15 Feb 2017 03:22:59 -0800 (PST)
In-Reply-To: <CALe+Z03-V+NWPYkHzUU7KbfTrEuLM4+7E4SU_sFrsTXaWo9VTQ@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-02-15 11:45, Jan Blunck:
> >  /**
> > + * Match the PCI Driver and Device using the ID Table
> > + *
> > + * @param pci_drv
> > + *     PCI driver from which ID table would be extracted
> > + * @param pci_dev
> > + *     PCI device to match against the driver
> > + * @return
> > + *     0 for successful match
> > + *     !0 for unsuccessful match
> > + */
> > +int
> > +rte_pci_match(const struct rte_pci_driver *pci_drv,
> > +             const struct rte_pci_device *pci_dev);
> 
> I don't think this symbol needs to be exported and visible outside of EAL.

If I remember well, Shreyansh wants to re-use it for its own bus which
is closed to PCI.
I think it is weird and we could look for another way to re-use some code.
Shreyansh?