From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2 0/2] ethdev: add support for raw flow type
	for flow director
Date: Wed, 04 Oct 2017 19:56:22 +0200
Message-ID: <2274280.QUHihWPneZ@xps>
References: <1503588634-85735-1-git-send-email-kirill.rybalchenko@intel.com>
 <13345393.msxc2hlS7D@xps> <e96e47fc-0ae3-84b0-930f-c0351c8b2094@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
 andrey.chilikin@intel.com, beilei.xing@intel.com, jingjing.wu@intel.com
To: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 4EA471B6CE
 for <dev@dpdk.org>; Wed,  4 Oct 2017 19:56:24 +0200 (CEST)
In-Reply-To: <e96e47fc-0ae3-84b0-930f-c0351c8b2094@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

04/10/2017 19:44, Ferruh Yigit:
> On 10/4/2017 5:57 PM, Thomas Monjalon wrote:
> > 03/10/2017 21:02, Ferruh Yigit:
> >> On 9/20/2017 9:42 AM, Kirill Rybalchenko wrote:
> >>> For complex packets use raw flow type with pre-constructed packet buffer
> >>> instead of creating a packet internally in PMD.
> > 
> > Sorry for not catching this series before.
> > 
> > As it has been said several times on this mailing list,
> > the flow director API is deprecated.
> > I think everybody here knows that it is going to be replaced
> > by rte_flow.
> > 
> > That's why it does not make sense to extend flow director.
> > We are not going to update PMDs to support a new type
> > of legacy flow director.
> > Please focus your efforts on rte_flow.
> 
> As far as I can see this is not to to extend flow director. But driver
> uses this struct and adding a new feature into driver requires update in
> this struct.
> 
> I guess idea was for new filter functionalities PMD should use rte_flow,
> that is the new shiny method we have, I see the point here. But I don't
> see the point of making these structs under use completely immutable.

I don't know what is RTE_ETH_FLOW_RAW.
Let's start by explaining it, how it is used by users,
and why this struct is needed.
Thanks