From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v12] devtools: alert on new instances of
	rte_panic and rte_exit
Date: Thu, 26 Jul 2018 23:00:26 +0200
Message-ID: <2274773.jc5eBGUB0q@xps>
References: <1531741077-5513-1-git-send-email-arnon@qwilt.com>
 <5378502.1ef9rKBE6e@xps>
 <CAKy9EB1AO+vDXmOqM+5fb-JXptyC4fDEBrXRuA3FqFOw75S-Rw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>, "Lu,
 Wenzhuo" <wenzhuo.lu@intel.com>, "Doherty, Declan" <declan.doherty@intel.com>,
 jerin.jacob@caviumnetworks.com, Bruce Richardson <bruce.richardson@intel.com>,
 "Yigit, Ferruh" <ferruh.yigit@intel.com>
To: Arnon Warshavsky <arnon@qwilt.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E0D1A288C
 for <dev@dpdk.org>; Thu, 26 Jul 2018 23:00:32 +0200 (CEST)
In-Reply-To: <CAKy9EB1AO+vDXmOqM+5fb-JXptyC4fDEBrXRuA3FqFOw75S-Rw@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

26/07/2018 22:57, Arnon Warshavsky:
> > > +     if [ $? -ne 0 ] ; then
> > > +             ret=1
> > > +     fi
> > > +     printf '%s\n' "$report"
> >
> > You are printing the report, no matter of the result? Why?
> > Is it because a warning does not return as an error?
> >
> There is maybe an improvement required here.
> >
> 
> Yes this is indeed the reason.
> Sticking to a simple success/fail in the return value with the price of
> printing an empty string in the case of no-warning seemed better than
> handling multiple (>2) return codes .
> Do you have a preferred way here?

My preference is to return an error if there is a warning.
The script itself must return an error code.

Thank you