From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] vhost: fix ANY_LAYOUT declaration
Date: Tue, 30 Jan 2018 21:48:54 +0100
Message-ID: <2279300.srBI6OA966@xps>
References: <1516388570-42634-1-git-send-email-zhihong.wang@intel.com>
 <6637c690-e659-ef2f-a077-d2a8e5f8b120@intel.com>
 <20180126130455.GC29540@yliu-mob>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Yuanhan Liu <yliu@fridaylinux.org>, "Tan,
 Jianfeng" <jianfeng.tan@intel.com>, Zhihong Wang <zhihong.wang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id DEBD91B702
 for <dev@dpdk.org>; Tue, 30 Jan 2018 21:49:43 +0100 (CET)
In-Reply-To: <20180126130455.GC29540@yliu-mob>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

There is a compilation error on Ubuntu 12.04 / kernel 3.8.
VIRTIO_F_ANY_LAYOUT is undeclared.


26/01/2018 14:04, Yuanhan Liu:
> On Sat, Jan 20, 2018 at 01:54:52AM +0800, Tan, Jianfeng wrote:
> > 
> > 
> > On 1/19/2018 10:42 PM, Yuanhan Liu wrote:
> > >On Fri, Jan 19, 2018 at 02:02:50PM -0500, Zhihong Wang wrote:
> > >>The VIRTIO_F_ANY_LAYOUT feature indicates the device accepts arbitrary
> > >>descriptor layouts. The vhost-user lib already supports it, but the
> > >>feature declaration is missing. This patch fixes the mismatch.
> > >I remembered there was a long discussion one year ago, that we can't
> > >blindly set this feature, as this flag is reserved (thus should not
> > >be set) for virtio 1.0.
> > 
> > We might need to read that old thread again. But as you said, this flag is
> > reserved for 1.0, but not used for other purpose yet. So that the feature is
> > negotiated does not affect anything, no?
> > 
> > >
> > >We should set it when v1.0 is not enabled.
> > 
> > But in fact, vhost kernel reports supported feature bits consisting of
> > ANY_LAYOUT and VERSION_1.
> 
> Yes, I was aware of that, and that was also one my points before.
> 
> I now also release that it's a must from migration from vhost-net to
> vhost-user. Thus, I'd like to merge it this time. So
> 
> Applied to dpdk-next-virtio.