From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v12 1/2] ethdev: Add a new event type to notify a queue state changed event Date: Fri, 18 Mar 2016 14:54:58 +0100 Message-ID: <2287874.v1n9VH3tqv@xps13> References: <1458030701-11487-1-git-send-email-mukawa@igel.co.jp> <1458030701-11487-2-git-send-email-mukawa@igel.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, bruce.richardson@intel.com, ann.zhuangyanying@huawei.com To: Tetsuya Mukawa Return-path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id EAF515937 for ; Fri, 18 Mar 2016 14:56:29 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id p65so70084493wmp.1 for ; Fri, 18 Mar 2016 06:56:29 -0700 (PDT) In-Reply-To: <1458030701-11487-2-git-send-email-mukawa@igel.co.jp> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-15 17:31, Tetsuya Mukawa: > This patch adds a below event type. > - RTE_ETH_EVENT_QUEUE_STATE_CHANGE > This event is used for notifying a queue state changed event. [...] > enum rte_eth_event_type { > RTE_ETH_EVENT_UNKNOWN, /**< unknown event type */ > RTE_ETH_EVENT_INTR_LSC, /**< lsc interrupt event */ > + RTE_ETH_EVENT_QUEUE_STATE_CHANGE, > + /**< queue state changed interrupt */ This comment is not really helpful. Please could you describe what is a queue state? Is it only applicable to vhost? Can we say there is a real interrupt or simply an event?