From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v7 1/4] lib/ether: optimize the'rte_eth_tunnel_filter_conf' structure Date: Wed, 09 Mar 2016 00:20:04 +0100 Message-ID: <2289873.4jna6JPa7N@xps13> References: <1456804032-1682-1-git-send-email-xutao.sun@intel.com> <1456821665-21831-2-git-send-email-xutao.sun@intel.com> <3772502.CAyHCzg1hr@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Xutao Sun Return-path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id D16E92BB4 for ; Wed, 9 Mar 2016 00:21:42 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id p65so48364133wmp.0 for ; Tue, 08 Mar 2016 15:21:42 -0800 (PST) In-Reply-To: <3772502.CAyHCzg1hr@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-09 00:08, Thomas Monjalon: > Hi, > > 2016-03-01 16:41, Xutao Sun: > > --- a/doc/guides/rel_notes/release_16_04.rst > > +++ b/doc/guides/rel_notes/release_16_04.rst > > @@ -123,6 +123,8 @@ ABI Changes > > the previous releases and made in this release. Use fixed width quotes for > > ``rte_function_names`` or ``rte_struct_names``. Use the past tense. > > > > +* The fields of outer_mac and inner_mac were changed from pointer > > + to struct in order to keep the code's readability. > > It is an API change. Proof: you changed the testpmd code. Please move it and reword to precise the ethdev context. Also the fields should be enclosed with backquotes as in the template.