From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] crypto/scheduler: fix build Date: Sun, 09 Jul 2017 15:26:00 +0200 Message-ID: <2291044.izmqMtvmdQ@xps> References: <20170709094416.15045-1-jblunck@infradead.org> <1582621.mDe9fsxt3G@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Jan Blunck Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 17FB858CB for ; Sun, 9 Jul 2017 15:26:02 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/07/2017 12:43, Jan Blunck: > On Sun, Jul 9, 2017 at 6:38 AM, Thomas Monjalon wrote: > > 09/07/2017 11:44, Jan Blunck: > >> Fixes 4c07e0552f0a ("crypto/scheduler: add multicore scheduling mode") > >> > >> drivers/crypto/scheduler/scheduler_multicore.c: In function 'scheduler_stop': > >> drivers/crypto/scheduler/scheduler_multicore.c:286:2: error: 'for' loop > >> initial declarations are only allowed in C99 or C11 mode > >> for (uint16_t i = 0; i < sched_ctx->nb_wc; i++) > >> ^ > > > > I wonder why I have not spotted it. > > What is your compiler? which version? > > This is with Debian Jessie: > > gcc version 4.9.2 (Debian 4.9.2-10) OK, so I could update the title to "fix build with old gcc" ? And add in the log that it has been seen with gcc 4.9.2. Do you agree? PS: I am testing with gcc 7.1.