From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: Question for queue_start
Date: Thu, 22 Mar 2018 13:59:55 +0100
Message-ID: <2293021.YCkHM76IOx@xps>
References: <039ED4275CED7440929022BC67E7061153171181@SHSMSX103.ccr.corp.intel.com>
 <2601191342CEEE43887BDE71AB977258A0AB30B1@irsmsx105.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id AC3485593
 for <dev@dpdk.org>; Thu, 22 Mar 2018 13:59:57 +0100 (CET)
In-Reply-To: <2601191342CEEE43887BDE71AB977258A0AB30B1@irsmsx105.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

22/03/2018 13:27, Ananyev, Konstantin:
> Hi Qi, 
> 
> 
> >Hi:
> >       In rte_eth_dev_rx|tx_queue_start, dev_started is not checked
> >         
> >      Which mean we can call  
> >         Rte_eth_rx_queue_setup
> >         Rte_eth_rx_qeueu_start         
> >
> >         And what we expected is the queue is started while device is still stopped, does this make sense?
> >         Should it return fail when device is not started?
> 
> Good point, I think we should.

Yes, I think there was no intent to start a queue of a stopped device.