From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] scripts: add check for net driver names without net prefix Date: Wed, 06 Jul 2016 11:46:23 +0200 Message-ID: <22935387.s4eUy1AmSX@xps13> References: <1467729650-925-1-git-send-email-bruce.richardson@intel.com> <6142444.k3HLHFvhXo@xps13> <20160706092524.GC17404@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, nelio.laranjeiro@6wind.com To: Bruce Richardson Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id CDD30567E for ; Wed, 6 Jul 2016 11:46:24 +0200 (CEST) Received: by mail-wm0-f49.google.com with SMTP id f126so166837076wma.1 for ; Wed, 06 Jul 2016 02:46:24 -0700 (PDT) In-Reply-To: <20160706092524.GC17404@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-07-06 10:25, Bruce Richardson: > On Wed, Jul 06, 2016 at 11:10:48AM +0200, Thomas Monjalon wrote: > > 2016-07-05 15:40, Bruce Richardson: > > > +# check headline label for net/ prefix if needed > > > +bad=$(echo "$headlines" | grep -E --color=always \ > > > + -e "^($(ls drivers/net | grep -v Makefile | tr '\n' '|')):" \ > > > + | sed 's,^,\t,') > > > +[ -z "$bad" ] || printf "Headline missing 'net/' prefix:\n$bad\n" > > > > This check is definitely a good idea. > > We need the same thing for crypto. > > Few nits: > > - -E is not needed for this regex > > - "/base:" cases are not handled because of the colon at the end > > of the regex. > > Good point. Easy enough to fix, I suspect. > > > - patches touching several drivers are not handled. Examples: > > "mlx:" -> "net/mlx:" > > "drivers/net:" -> "net:" > > > Yes, however, those are in the minority of cases, and we can always add > special case extra regex's for those - hardcoded like the other regex's in the > file. I did the pulling directory list so we don't have to update the checks > every time a new driver was added. Another issue: I suspect you will have false positives with librte_ring and librte_vhost. > > By the way, I am looking at an idea, that Nelio sent me, based on > > modified files. It can complete this check. > > Great. I'll look forward to seeing that. If it works out well, by all means > drop this patch. If it's not coming any time soon though, I can do a V2 of > this patch, but I won't bother right now in the expectation that a better > solution is coming. My concern is that the file-based solution will handle only the patches where every changes are in drivers/ (not config/ or anything else). I'm thinking how to merge both solutions. I'm also concerned by the time passed developing these checks ;)