From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 0/6] Extensions to test-pmd Date: Fri, 16 May 2014 16:22:58 +0200 Message-ID: <2296399.R20Tya40om@xps13> References: <1396546216-29200-1-git-send-email-cchemparathy@tilera.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Cyril Chemparathy Return-path: In-Reply-To: <1396546216-29200-1-git-send-email-cchemparathy-kv+TWInifGbQT0dZR+AlfA@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Cyril, 2014-04-03 10:30, Cyril Chemparathy: > This patch series contains a few minor extensions to test-pmd. These > changes have been added primarily for convenience while testing out various > scenarios with DPDK. > > Cyril Chemparathy (6): > test-pmd: add support for single port loopback topology > test-pmd: add support for auto-start when interactive > test-pmd: allow command line selection of forwarding mode > test-pmd: allow txpkts to be setup via command line > test-pmd: add mac swap forwarding mode > test-pmd: add flowgen forwarding engine Thanks for these new features. This is not the first time a new engine is added by copy/pasting the most part of an existing engine. For instance, the "mac-retry" engine was added by Intel as a copy/paste of the original "mac" one. This is acceptable but not the perfect way to implement engines. To address this issue, a new engine function could be introduced to setup some parameters to be used by "packet_fwd" function. This way, similar engines could be removed. Acked-by: Thomas Monjalon Applied for version 1.7.0. -- Thomas