From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v7 00/10] ipsec: new library for IPsec
	data-path processing
Date: Thu, 10 Jan 2019 15:54:55 +0100
Message-ID: <2299789.JsJELPjGV9@xps>
References: <1546546586-22009-2-git-send-email-konstantin.ananyev@intel.com>
 <1589360.MiOzkj7FWM@xps>
 <2601191342CEEE43887BDE71AB977258010D901C95@irsmsx105.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
 "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id BA3FB1B8B7
 for <dev@dpdk.org>; Thu, 10 Jan 2019 15:55:00 +0100 (CET)
In-Reply-To: <2601191342CEEE43887BDE71AB977258010D901C95@irsmsx105.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

10/01/2019 15:52, Ananyev, Konstantin:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 10/01/2019 15:20, Konstantin Ananyev:
> > > v6 -> v7
> > > - Changes to address Thomas comments:
> > >     bump ABI version
> > >     remove related deprecation notice
> > >     update release notes, ABI changes section
> > 
> > You did not update the lib versions in the release notes.
> 
> For 'security: add opaque userdata pointer into security session':
> 1) removed deprecation notice
> 2) add ABI change into release note:
> +* security: New field ``uint64_t opaque_data`` is added into
> +  ``rte_security_session`` structure. That would allow upper layer to easily
> +  associate/de-associate some user defined data with the security session.
> +
> 3) Bumbed version in Makefile and meson.build
> 
> What else needs to be done here?

Like I said, "update the lib versions in the release notes".
Please check at the bottom of the page, there is a list of libraries.

> > I think you missed a deprecation notice removal in patch 1.
> As Pablo noticed that would happen in "cryptodev: update symmetric session",
> this patch will be just dropped from the series.

OK

> > Have you checked the doxygen warnings in last patch?
> I think I fixed that in v7, are still seeing them?

OK
I did not check. It was just a question because it is not in the changelog.