From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v6 0/7] rte_hash_crc reworked to be platform-independent Date: Mon, 23 Feb 2015 18:36:57 +0100 Message-ID: <2302266.QHkfKt2YM8@xps13> References: <1409724351-23786-1-git-send-email-e_zhumabekov@sts.kz> <54CF0D86.3090507@sts.kz> <20150219152129.GA17032@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Yerden Zhumabekov Return-path: In-Reply-To: <20150219152129.GA17032@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2015-02-19 15:21, Bruce Richardson: > Confirmed, this worked for me too. > Looking at the patches, they look good. However, one thing I think we are missing > is a unit test to verify that all our CRC implementations give the same result. > That would be useful as a sanity check of the software fallback especially. The > existing hash tests, test the hash table implementation rather than the > mathematical argorithm used to compute the hash values. > > Overall, though, software fallback for CRC is something well worthwhile having. > > Series Acked-by: Bruce Richardson Applied, thanks Note: running doxygen compilation helped me to find and fix a small mismatch (parameter alg was flag in comment).