From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 00/15] devargs fixes Date: Sat, 15 Jul 2017 20:20:41 +0200 Message-ID: <2305334.OuEkxHkjai@xps> References: <20170711232512.54641-1-jblunck@infradead.org> <20170714211213.34436-1-jblunck@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Jan Blunck Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id DF8BE2BC7 for ; Sat, 15 Jul 2017 20:20:48 +0200 (CEST) In-Reply-To: <20170714211213.34436-1-jblunck@infradead.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/07/2017 23:11, Jan Blunck: > The changes to enum rte_devtype that got merged into 17.08-rc1 are breaking > API without prior notice. This series is reworking the rte_devargs changes > in a way hopefully compliant to the new failover PMD and still keeping API > compatible with earlier releases. > > The introduced changes to 17.08-rc1 are trading the tightly coupling of > struct rte_devargs to the PCI and vdev bus against the struct rte_bus. > The changes proposed in this series decouple struct rte_devargs from > the new dependencies. > > Changes since v1: > - explicitly pass busname to rte_eal_devargs_parse() and validate it > - better explain why changes are done Most of these changes does not seem to fix a bug or an API break. Before -rc1, we can take them for the sake of cleaning. But after -rc1, we must take only fixes. If I understand well, the urgent fix to make in -rc2 is to revert an API break without prior notice. Which change is it? rte_devtype? The plan is to fix hotplug/devargs while integrating failsafe in -rc2. After releasing -rc2, we must agree on the planned clean-up and be sure that the right deprecation notices are in 17.08. Then we will integrate all these patches in August for 17.11.