From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] eal: fix compilation without VFIO
Date: Fri, 13 Apr 2018 15:08:27 +0200
Message-ID: <23085973.mySOohilc8@xps>
References: <20180412133422.104155-1-shahafs@mellanox.com>
 <7325634.395TUUszRC@xps> <dd2307a5-9990-2453-1f5e-71680f472046@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Shahaf Shuler <shahafs@mellanox.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 9F6E01BB67
 for <dev@dpdk.org>; Fri, 13 Apr 2018 15:08:29 +0200 (CEST)
In-Reply-To: <dd2307a5-9990-2453-1f5e-71680f472046@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

13/04/2018 11:11, Burakov, Anatoly:
> On 13-Apr-18 12:39 AM, Thomas Monjalon wrote:
> > 12/04/2018 16:13, Burakov, Anatoly:
> >> On 12-Apr-18 2:34 PM, Shahaf Shuler wrote:
> >>> a compilation error occurred when compiling with CONFIG_RTE_EAL_VFIO=n
> >>>
> >>> == Build lib/librte_eal/linuxapp/eal
> >>>     CC eal_vfio.o
> >>> /download/dpdk/lib/librte_eal/linuxapp/eal/eal_vfio.c:1535:1: error: no
> >>> previous prototype for 'rte_vfio_dma_map' [-Werror=missing-prototypes]
> >>>    rte_vfio_dma_map(uint64_t __rte_unused vaddr, __rte_unused uint64_t
> >>> iova,
> >>>    ^
> >>> /download/dpdk/lib/librte_eal/linuxapp/eal/eal_vfio.c:1542:1: error: no
> >>> previous prototype for 'rte_vfio_dma_unmap' [-Werror=missing-prototypes]
> >>>    rte_vfio_dma_unmap(uint64_t __rte_unused vaddr, uint64_t __rte_unused
> >>> iova,
> >>>    ^
> >>>
> >>> As there is no use for those dummy functions without VFIO removing them
> >>> completely.
> >>
> >> These functions are part of public API, like rest of functions in this
> >> header. They're in the map file. Should we perhaps go the BSD way and
> >> provide EAL with dummy prototypes as well? See bsdapp/eal/eal.c:763 onwards.
> > 
> > Why using dummy prototypes?
> > Because the prototypes in rte_vfio.h are under #ifdef VFIO_PRESENT ?
> > Is it possible to always define the prototypes in rte_vfio.h ?
> > 
> 
> Well, technically, yes, we could. There is one function that uses a 
> VFIO-specific struct definition:
> 
> int rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,
> 		int *vfio_dev_fd, struct vfio_device_info *device_info);
> 
> I'm sure we can work around that.


Removing dummy prototypes need, would be a nicer fix.