From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] examples: ethtool: Link against
	librte_pmd_ixgbe if necessary
Date: Tue, 04 Apr 2017 12:15:14 +0200
Message-ID: <2310633.U6SXsHI9VC@xps13>
References: <20170216161731.4590-1-mchandras@suse.de>
 <1762973.YT1Za91pN5@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Nirmoy Das <ndas@suse.de>, "Iremonger,
 Bernard" <bernard.iremonger@intel.com>, Remy Horton <remy.horton@intel.com>
To: Markos Chandras <mchandras@suse.de>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f169.google.com (mail-wr0-f169.google.com
 [209.85.128.169]) by dpdk.org (Postfix) with ESMTP id 19C3C326C
 for <dev@dpdk.org>; Tue,  4 Apr 2017 12:15:17 +0200 (CEST)
Received: by mail-wr0-f169.google.com with SMTP id k6so203002321wre.2
 for <dev@dpdk.org>; Tue, 04 Apr 2017 03:15:17 -0700 (PDT)
In-Reply-To: <1762973.YT1Za91pN5@xps13>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Ping

2017-03-09 21:13, Thomas Monjalon:
> 2017-02-16 16:17, Markos Chandras:
> > The librte_ethtool library depends on librte_pmd_ixgbe if that
> > pmd driver is enabled so we need to link against it when we compile
> > the ethtool application. It fixes the following build problem:
> > 
> > /usr/lib64/gcc/x86_64-suse-linux/6/../../../../x86_64-suse-linux/bin/ld:
> > warning: librte_pmd_ixgbe.so.1, needed by /home/abuild/rpmbuild/BUILD/
> > dpdk-17.02/examples/ethtool/lib/x86_64-native-linuxapp-gcc/lib/
> > librte_ethtool.so, not found (try using -rpath or -rpath-link)
> > /home/abuild/rpmbuild/BUILD/dpdk-17.02/examples/ethtool/lib/
> > x86_64-native-linuxapp-gcc/lib/librte_ethtool.so: undefined reference to
> > `rte_pmd_ixgbe_set_vf_rxmode@DPDK_17.02'
> > collect2: error: ld returned 1 exit status
> 
> We may add this line:
> Fixes: 077d223e25c3 ("examples/ethtool: use ixgbe public function")
> 
> > Cc: Nirmoy Das <ndas@suse.de>
> > Signed-off-by: Markos Chandras <mchandras@suse.de>
> [...]
> > --- a/examples/ethtool/ethtool-app/Makefile
> > +++ b/examples/ethtool/ethtool-app/Makefile
> > +ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y)
> > +LDLIBS += -lrte_pmd_ixgbe
> > +endif
> 
> Please, could you confirm we can remove the same LDLIBS line from
> examples/ethtool/lib/Makefile ?