From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] build: establish an invariant machine type Date: Sun, 18 Nov 2018 14:24:04 +0100 Message-ID: <2310639.fA7hNCVAbZ@xps> References: <20181114135445.GA13408@bricha3-MOBL.ger.corp.intel.com> <20181114143315.2695-1-christian.ehrhardt@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Luca Boccassi , Bruce Richardson To: Christian Ehrhardt Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 094D01F28 for ; Sun, 18 Nov 2018 14:24:06 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/11/2018 20:39, Christian Ehrhardt: > On Wed, Nov 14, 2018 at 3:33 PM Christian Ehrhardt > wrote: > > > > Add the machine definition 'default' which is special compared > > to 'native' (most optimized for current system) or any explicit > > type (external entity has to decide on the type). > > > > It defaults to the per arch agreed common minimal baseline > > needed for DPDK to reasonable work. > > > > That might not be the most optimized, but the most portable > > version while still being able to support the CPU features > > required for DPDK. > > > > Going forward this can be bumped up by the DPDK project, but it > > can never be an invariant like 'native'. > > > > Distributions and other needing portable code are expected to > > define the machine as 'default'. > > > > Changes in v2: > > - fixed the non 64 bit arm default type > > - changed baseline to default to match the old build system > > > > Changes in v3: > > - add acked-by's > > - removed old wording from commit message > > - adding Fixes line per request by Luca Boccassi > > FYI: I'll drop the version update from the commit (I didn't have a > cover letter to add them instead). You don't need a cover letter for changelogs. You can insert it after --- Usually, I insert changelogs between two --- lines.