From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] qos_meter: Fix compilation with APP_MODE_FWD Date: Tue, 25 Aug 2015 15:42:55 +0200 Message-ID: <2313107.TsUIiMEBE8@xps13> References: <1439913312-14761-1-git-send-email-ian.stokes@intel.com> <1677849.ZVAMZEjUYk@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Mcnamara, John" Return-path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id DB0E45A33 for ; Tue, 25 Aug 2015 15:44:07 +0200 (CEST) Received: by wicne3 with SMTP id ne3so15769281wic.0 for ; Tue, 25 Aug 2015 06:44:07 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-08-25 13:34, Mcnamara, John: > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > > This patch should not be accepted to discourage build-time options. > > Patch for run-time option is welcome. > > The patch is fixing a compilation issue, which seems reasonable. It isn't > introducing a build time option, it is merely fixing an typo in an > existing one. Yes > Yes, it would be better not to have this build time option (in which case > the issue would have been found sooner) but that isn't the responsibility > of the person submitting this patch. Yes > That is something that should be pushed back to the author/maintainer. Yes > In the meantime this patch is still valid and should be applied. No After trying to request this kind of cleanup for several months, nothing happens. Maybe it will be more efficient to leave bugs until someone submit a real cleanup.