From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2 4/6] bond: free mbufs if transmission
	fails in bonding tx_burst functions
Date: Tue, 02 Sep 2014 11:31:52 +0200
Message-ID: <2319059.S7dZfdPe5P@xps13>
References: <1408456313-28812-1-git-send-email-declan.doherty@intel.com>
 <1409560289-29558-5-git-send-email-declan.doherty@intel.com>
 <345C63BAECC1AD42A2EC8C63AFFC3ADC2737656B@IRSMSX101.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: "Doherty, Declan" <declan.doherty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <345C63BAECC1AD42A2EC8C63AFFC3ADC2737656B-kPTMFJFq+rF9qrmMLTLiibfspsVTdybXVpNB7YpNyf8@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi Declan,

2014-09-02 09:22, Doherty, Declan:
> I've just noticed that I inserted an extra character into the patch when I was annotating this
> patch which will cause this a fail compilation.
> 
> > +			TEST_BCAST_SLAVE_TX_FAIL_BURST_SIZE -s
> > +			TEST_BCAST_SLAVE_TX_FAIL_MIN_PACKETS_COUNT);
> 
> should have been 
> > +			TEST_BCAST_SLAVE_TX_FAIL_BURST_SIZE -
> > +			TEST_BCAST_SLAVE_TX_FAIL_MIN_PACKETS_COUNT);
> 
> Thomas, do you want me to submit a V3 of this?

I'd prefer to have some comments first.
Anyone to review this patchset?

-- 
Thomas