From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] sched: fix useless call Date: Fri, 13 May 2016 12:12:25 +0200 Message-ID: <2334631.A0rgQzR3nq@xps13> References: <1462875064-119474-1-git-send-email-danielx.t.mrzyglod@intel.com> <3EB4FA525960D640B5BDFFD6A3D89126479BAF1D@IRSMSX108.ger.corp.intel.com> <5732FF68.50801@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Ferruh Yigit , "Mrzyglod, DanielX T" To: "Dumitrescu, Cristian" Return-path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id D52AD8E65 for ; Fri, 13 May 2016 12:12:27 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id a17so21861552wme.0 for ; Fri, 13 May 2016 03:12:27 -0700 (PDT) In-Reply-To: <5732FF68.50801@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-05-11 10:46, Ferruh Yigit: > On 5/10/2016 6:18 PM, Dumitrescu, Cristian wrote: > > As previously discussed on this email list, the rte_bitmap_free() is an API function that works as a placeholder for any resource freeing that needs to be done for the bitmap. The API function should not be removed and also the call to this function from the rte_sched_port_free() should not be removed either. > > > > Right now it isn't required and doesn't do anything. > Why not add this function when it is required? I don't understand why we keep a function which does nothing.