From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] Fix librte_pmd_pcap driver double stop error Date: Thu, 09 Oct 2014 21:10:21 +0200 Message-ID: <2347562.QcBRlqmUyU@xps13> References: <20141006145020.GE22304@hmsreliant.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: dev-VfR2kkLFssw@public.gmane.org To: =?ISO-8859-1?Q?Nicol=E1s?= Pernas Maradei Return-path: In-Reply-To: <20141006145020.GE22304-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" > > New in Patch v2: > >=20 > > - Fixes an issue in eth_dev_start/stop where a single interface was= always > > opened/closed even though pcap files had been selected for rx/tx st= reams. > > - The link_status was not being properly updated in case of using a= single > > interface for rx/tx streams. > >=20 > > On 2014-10-04 23:24, Nicol=E1s Pernas Maradei wrote: > > > > > >librte_pmd_pcap driver was opening the pcap/interfaces only at ini= t time > > >and > > >closing them only when the port was being stopped. This behaviour = would > > >cause > > >problems (leading to segfault) if the user closed the port 2 times= . The > > >first > > >time the pcap/interfaces would be normally closed but libpcap woul= d throw > > >an > > >error causing a segfault if the closed pcaps/interfaces were close= d again. > > >This behaviour is solved by re-openning pcaps/interfaces when the = port is > > >started (only if these weren't open already for example at init ti= me). > > > > > >Signed-off-by: Nicol=E1s Pernas Maradei >=20 > Acked-by: Neil Horman Applied Thanks --=20 Thomas